Reviewers: dcarney,
Message:
PTAL.
2nd try for PersistentValueMap, w/ fix for user-after-free discovered by
Win32/debug bot.
Description:
Implement PersistentValueMap, a map that stores UniquePersistent values.
This is preparatory work to get rid of UnsafePersistent in blink.
The previous version had to be reverted due to timeouts in win32/Debug:
https://codereview.chromium.org/197173002/
The timeouts happened because the STL version on that platform contains
sanity
checking code which opens a 'debug window' in the GUI, patiently waiting
for the
user to click ok/cancel/somethirdoption. It turns out, the cause for that
debug
window was totally valid and the test had a use-after-free issue.
The 1st patch set is the code as before. The 2nd patch set contains the fix.
Related blink changes are here: https://codereview.chromium.org/180363004/
This patch is largely based on https://codereview.chromium.org/175503003/,
with
some methods added to support the blink change mentioned above.
BUG=
Please review this at https://codereview.chromium.org/197263002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+314, -11 lines):
M include/v8.h
M src/api.cc
M src/global-handles.h
M src/global-handles.cc
M test/cctest/test-api.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
