LGTM. I'll fix the nit on landing.
https://codereview.chromium.org/198163002/diff/1/src/mips/frames-mips.h
File src/mips/frames-mips.h (right):
https://codereview.chromium.org/198163002/diff/1/src/mips/frames-mips.h#newcode166
src/mips/frames-mips.h:166: static const int kConstantPoolOffset = 0;
We should say '// Not used.' here as the other (non-Arm) arch's do.
https://codereview.chromium.org/198163002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
