On 2014/03/13 06:16:18, jarin wrote:
lgtm, although I am not sure how the change to GitDiff relates to the
change
in
the test.
The change in the code will cause two calls to git instead of one. The
first is
(in the context of the test):
git diff --name-only svn/trunk hash1
to get the list of changed files - the test driver will make it return
"file1\nfile2\n" after which git is expected to execute again like this:
git diff svn/trunk hash1 file1 file2
https://codereview.chromium.org/197023004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
