https://codereview.chromium.org/197653002/diff/1/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/197653002/diff/1/src/parser.h#newcode484
src/parser.h:484: // with JSC we choose to report the error at runtime.
Do we have plans to fix this eventually? It's clearly a spec violation,
and I don't think we have to worry about JSC any longer.

https://codereview.chromium.org/197653002/diff/1/src/preparser.h
File src/preparser.h (right):

https://codereview.chromium.org/197653002/diff/1/src/preparser.h#newcode1559
src/preparser.h:1559: return this->ParseYieldExpression(ok);
On 2014/03/13 08:52:41, Michael Starzinger wrote:
As discussed offline: It would be nice to get rid of all this explicit
"this->"
prefixes. But since this is on your plate as final cleanup anyways, I
am fine
with it.

FWIW, I like the explicit this->, and would prefer a style guide that
requires them, always. Makes reading and esp refactoring so much easier.
Remember handlification? :)

https://codereview.chromium.org/197653002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to