LGTM with nits. Thanks!
https://codereview.chromium.org/199013002/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/199013002/diff/1/src/x64/lithium-codegen-x64.cc#newcode3611
src/x64/lithium-codegen-x64.cc:3611: Label done, round_to_zero,
below_one_half, do_not_compensate, restore;
We don't need |restore| anymore. And we don't need |do_not_compensate|
either ;-)
https://codereview.chromium.org/199013002/diff/1/test/mjsunit/regress/regress-351624.js
File test/mjsunit/regress/regress-351624.js (right):
https://codereview.chromium.org/199013002/diff/1/test/mjsunit/regress/regress-351624.js#newcode13
test/mjsunit/regress/regress-351624.js:13: print("input: " + prod);
don't need print() for non-interactive use
https://codereview.chromium.org/199013002/diff/1/test/mjsunit/regress/regress-351624.js#newcode16
test/mjsunit/regress/regress-351624.js:16: if (prod !== backup[0]) throw
new Error("arg!");
use assertEquals(backup[0], prod) here
https://codereview.chromium.org/199013002/diff/1/test/mjsunit/regress/regress-351624.js#newcode24
test/mjsunit/regress/regress-351624.js:24: if (result != -big) {
assertEquals(-big, result)
https://codereview.chromium.org/199013002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
