[v8-dev] MIPS: Remove uses of CanBeNegative() in HMod. (issue 197463008)

Thu, 13 Mar 2014 10:06:40 -0700 

Reviewers: danno, Benedikt Meurer, Paul Lind, kisg, palfia, dusmil,

Description:
MIPS: Remove uses of CanBeNegative() in HMod.

Port r19878 (74a9002)

BUG=v8:3204
LOG=y

Please review this at https://codereview.chromium.org/197463008/

SVN Base: https://github.com/v8/v8.git@gbl

Affected files (+1, -1 lines):
  M src/mips/lithium-codegen-mips.cc


Index: src/mips/lithium-codegen-mips.cc
diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc index d8af6a67c799d96c5133662b82b0f78f5d2a4c96..d9619ed0e87513006ad9151e2065e70c37fbbf68 100644 
--- a/src/mips/lithium-codegen-mips.cc
+++ b/src/mips/lithium-codegen-mips.cc
@@ -1082,7 +1082,7 @@ void LCodeGen::DoModByPowerOf2I(LModByPowerOf2I* instr) { 
   int32_t mask = divisor < 0 ? -(divisor + 1) : (divisor - 1);
   Label dividend_is_not_negative, done;

-  if (hmod->left()->CanBeNegative()) {
+  if (hmod->CheckFlag(HValue::kLeftCanBeNegative)) {
     __ Branch(&dividend_is_not_negative, ge, dividend, Operand(zero_reg));
     // Note: The code below even works when right contains kMinInt.
     __ subu(dividend, zero_reg, dividend);


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to