Reviewers: ulan, jochen,
Description:
A64: Handle a few TODOs.
Below are notes about some of the TODOs handled.
* In Simulator::Debug:
We haven't had issues with printing in the debugger for a while. If the
feature turns out to be still lacking an issue can be raised.
* In SubStringStub::Generate:
There is no need to jump there. The StringCharAtGenerator is asked to
set
the result in x0, and the return sequence following only uses two
instructions.
Also, we would need to jump after the native counter increment instead
of
the
return_x0 label.
* In ArrayPushStub::Generate:
Raised an internal issue to check and update the ARM code.
* In MacroAssembler::CopyBytes:
The new code should be faster for bulk copies. Raised an internal issue
to
investigate and improve this function.
* In MacroAssembler::EnterExitFrame:
Unless we actually find something is wrong, this is working and looks
ok.
Also fixed the comments about the FP registers.
* Comment for BumpSystemStackPointer:
Removed the comment at the declaration site and updated the TODO in the
implementation.
Please review this at https://codereview.chromium.org/196473021/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+90, -67 lines):
M src/a64/code-stubs-a64.cc
M src/a64/macro-assembler-a64-inl.h
M src/a64/macro-assembler-a64.h
M src/a64/macro-assembler-a64.cc
M src/a64/simulator-a64.h
M src/a64/simulator-a64.cc
M src/a64/stub-cache-a64.cc
M src/a64/utils-a64.h
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
