On 2014/03/14 12:35:57, rmcilroy wrote:
https://codereview.chromium.org/188063002/diff/40001/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/188063002/diff/40001/src/deoptimizer.cc#newcode1136
src/deoptimizer.cc:1136: // Our constant pool is the same as our
caller's, get
it from the previous
On 2014/03/13 13:35:22, ulan wrote:
> Why ArgumentsAdaptorTrampoline and other stubs below have the same
constant
pool
> as their callers?
You are right - originally stubs didn't load the constant pool pointer so
it
was
the case that their cp was the same as their callers, but now with the
FrameAndConstantPoolScope they can load their own constant pool. I've
made
this
change (which also required updating LeaveArgumentsAdapterFrame to
restore the
pp register).
Thanks for clarification! LGTM
https://codereview.chromium.org/188063002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
