Revision: 19934
Author:   [email protected]
Date:     Fri Mar 14 13:22:14 2014 UTC
Log:      Remove unused irregexp cache.

[email protected]

Review URL: https://codereview.chromium.org/200303002
http://code.google.com/p/v8/source/detail?r=19934

Modified:
 /branches/bleeding_edge/src/interpreter-irregexp.cc
 /branches/bleeding_edge/src/isolate.h

=======================================
--- /branches/bleeding_edge/src/interpreter-irregexp.cc Mon Jun 3 15:32:22 2013 UTC +++ /branches/bleeding_edge/src/interpreter-irregexp.cc Fri Mar 14 13:22:14 2014 UTC
@@ -159,24 +159,11 @@
 class BacktrackStack {
  public:
   explicit BacktrackStack(Isolate* isolate) : isolate_(isolate) {
-    if (isolate->irregexp_interpreter_backtrack_stack_cache() != NULL) {
-      // If the cache is not empty reuse the previously allocated stack.
-      data_ = isolate->irregexp_interpreter_backtrack_stack_cache();
-      isolate->set_irregexp_interpreter_backtrack_stack_cache(NULL);
-    } else {
-      // Cache was empty. Allocate a new backtrack stack.
-      data_ = NewArray<int>(kBacktrackStackSize);
-    }
+    data_ = NewArray<int>(kBacktrackStackSize);
   }

   ~BacktrackStack() {
-    if (isolate_->irregexp_interpreter_backtrack_stack_cache() == NULL) {
-      // The cache is empty. Keep this backtrack stack around.
-      isolate_->set_irregexp_interpreter_backtrack_stack_cache(data_);
-    } else {
-      // A backtrack stack was already cached, just release this one.
-      DeleteArray(data_);
-    }
+    DeleteArray(data_);
   }

   int* data() const { return data_; }
=======================================
--- /branches/bleeding_edge/src/isolate.h       Mon Mar 10 08:56:48 2014 UTC
+++ /branches/bleeding_edge/src/isolate.h       Fri Mar 14 13:22:14 2014 UTC
@@ -353,8 +353,6 @@
V(Relocatable*, relocatable_top, NULL) \ V(DebugObjectCache*, string_stream_debug_object_cache, NULL) \ V(Object*, string_stream_current_security_token, NULL) \ - /* TODO(isolates): Release this on destruction? */ \ - V(int*, irregexp_interpreter_backtrack_stack_cache, NULL) \ /* Serializer state. */ \ V(ExternalReferenceTable*, external_reference_table, NULL) \ /* AstNode state. */ \

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to