Reviewers: dcarney,
Message:
This is a continuation of issue 195793024. Please have a look.
I'm not really sure where to go with this, so the two patch sets are
essentially
two different proposals of where to go. The 2nd one looks nicer and is
arguably
easier to use, at least when you get by with the provided default traits.
https://codereview.chromium.org/201643003/diff/20001/include/v8-util.h
File include/v8-util.h (right):
https://codereview.chromium.org/201643003/diff/20001/include/v8-util.h#newcode42
include/v8-util.h:42: typedef uintptr_t PersistentContainerValue;
This definition is a bit random... I guess it should go into
PersistentValueMap, since it really describes the implementation between
PersistentValueMap and the MapTraits?
https://codereview.chromium.org/201643003/diff/20001/include/v8-util.h#newcode46
include/v8-util.h:46: namespace util {
q: This namespace mainly serves to make the Traits classes available to
users, without polluting the main v8 namespace. Does that make sense? Or
should the entire PersistentValueMap go into this namespace?
Description:
First attempt at providing default traits for PersistentValueMap.
BUG=
Please review this at https://codereview.chromium.org/201643003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+319, -222 lines):
A include/v8-util.h
M include/v8.h
M test/cctest/test-api.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
