On 2014/03/17 16:04:08, Yang wrote:
On 2014/03/13 11:57:38, Yang wrote:
> On 2014/02/25 17:46:21, Yang wrote:
> > On 2014/02/25 17:44:28, ulan wrote:
> > > PTAL
> > >
> > >
> >
>

https://codereview.chromium.org/180053003/diff/1/test/mjsunit/compiler/concurrent-invalidate-transition-map.js
> > > File test/mjsunit/compiler/concurrent-invalidate-transition-map.js
(right):
> > >
> > >
> >
>

https://codereview.chromium.org/180053003/diff/1/test/mjsunit/compiler/concurrent-invalidate-transition-map.js#newcode47
> > > test/mjsunit/compiler/concurrent-invalidate-transition-map.js:47:
> > > add_field(obj);
> > > If GC happens between the calls and there is no live instance of
new_object
> > then
> > > then transition in add_field will be collected, so on the next call to
> > add_field
> > > the obj.c IC will not turn MONOMORPHIC.
> >
> > LGTM.
>
> Is this no longer relevant?

dumdidum :)

Fixed test, landing.

https://codereview.chromium.org/180053003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to