https://codereview.chromium.org/200363002/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):
https://codereview.chromium.org/200363002/diff/1/src/json-stringifier.h#newcode658
src/json-stringifier.h:658: if (property.is_null()) return EXCEPTION;
RETURN_IF_EMPTY_HANDLE_VALUE(isolate_, property, EXCEPTION);
https://codereview.chromium.org/200363002/diff/1/src/liveedit.cc
File src/liveedit.cc (right):
https://codereview.chromium.org/200363002/diff/1/src/liveedit.cc#newcode1954
src/liveedit.cc:1954: if (*obj ==
Smi::FromInt(LiveEdit::FUNCTION_BLOCKED_ON_ACTIVE_STACK)) {
Extra space after ==
https://codereview.chromium.org/200363002/diff/1/src/log.cc
File src/log.cc (right):
https://codereview.chromium.org/200363002/diff/1/src/log.cc#newcode1212
src/log.cc:1212: Object::GetElement(isolate_, args_handle, format[i] -
'0');
I'm afraid we can hit ASSERT(AllowHeapAllocation::IsAllowed()); inside
GetElement() in case of call from Runtime_Log().
https://codereview.chromium.org/200363002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
