Reviewers: Hannes Payer,
Description:
Fix race between VisitSmiRoots and SetStackLimit.
[email protected]
Please review this at https://codereview.chromium.org/198833006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -0 lines):
M src/heap.cc
Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index
66b527456e6ec53b1f149b378576a08b59b614a9..4855ac08aeb8e1a56b23df4e527edd97208e977e
100644
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -6161,6 +6161,8 @@ void Heap::IterateWeakRoots(ObjectVisitor* v,
VisitMode mode) {
void Heap::IterateSmiRoots(ObjectVisitor* v) {
+ // Acquire execution access since we are going to read stack limit
values.
+ ExecutionAccess access(isolate());
v->VisitPointers(&roots_[kSmiRootsStart], &roots_[kRootListLength]);
v->Synchronize(VisitorSynchronization::kSmiRootList);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
