On 2014/03/17 18:06:46, Jakob wrote:
Do we have test coverage for all code paths that have changed? It's easy
to
introduce a typo when refactoring jump conditions, accidentally reversing
a
condition...
https://codereview.chromium.org/202083002/diff/1/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):
https://codereview.chromium.org/202083002/diff/1/src/x64/macro-assembler-x64.cc#newcode3076
src/x64/macro-assembler-x64.cc:3076: j(below_equal, &done, Label::kNear);
This change is confusing. "zero" should have the same effect
as "below_equal"
in
this case, and is much more readable. Or am I missing something?
Hi Jakob,
I assume there are test coverage for the whole code paths. But I am not sure
because the changes occurs in quite a lot different path although I changed
it
very carefully.
It seems time consuming to construct a test case to cover them all. But I
could
do it if it is necessary for landed.
https://codereview.chromium.org/202083002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
