LGTM
https://codereview.chromium.org/200763013/diff/1/tools/push-to-trunk/push_to_trunk.py
File tools/push-to-trunk/push_to_trunk.py (left):
https://codereview.chromium.org/200763013/diff/1/tools/push-to-trunk/push_to_trunk.py#oldcode341
tools/push-to-trunk/push_to_trunk.py:341:
self.GitAdd(self.Config(VERSION_FILE))
Are you sure we don't need this anymore, having just modified the file?
Even if it was staged for commit before, I think the modifications have
to be staged explicitly again.
https://codereview.chromium.org/200763013/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
