https://codereview.chromium.org/203193004/diff/40001/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/203193004/diff/40001/src/parser.h#newcode513
src/parser.h:513: bool ShortcutLiteralUnaryExpression(
Nit: not sure I like the name. This is doing constant folding, so maybe
rather call it FoldUnaryExpression (and say "constant-fold" instead of
"shortcut" in the comment.
https://codereview.chromium.org/203193004/diff/40001/src/parser.h#newcode521
src/parser.h:521: bool AddUnaryExpressionTypeFeedback(
Similarly here. I'd perhaps call this RewriteUnaryExpression.
In fact, wouldn't it be possible to merge both these helpers into one
function returning the actual expression directly, such that you can
simply do
return BuildUnaryExpression(expression, op, pos, factory())
in ParseUnaryExpression (after checking the DELETE case)?
https://codereview.chromium.org/203193004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
