https://codereview.chromium.org/203333004/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/203333004/diff/1/src/objects.cc#newcode11447
src/objects.cc:11447: if (!array->map()->is_observed())
On 2014/03/19 13:38:48, Toon Verwaest wrote:
Use { } if multiline
Done.
https://codereview.chromium.org/203333004/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/203333004/diff/20001/src/objects.cc#newcode11442
src/objects.cc:11442: // static
On 2014/03/19 13:54:20, Yang wrote:
I think you can remove that comment too.
Done.
https://codereview.chromium.org/203333004/diff/20001/src/objects.cc#newcode11455
src/objects.cc:11455: Handle<Object> new_length_handle = length;
On 2014/03/19 13:54:20, Yang wrote:
Can we either rename the argument or rename the uses? So that we don't
have this
duplicate.
Done.
https://codereview.chromium.org/203333004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
