On 2014/03/19 15:06:29, Yang wrote:
LGTM.
https://codereview.chromium.org/204103008/diff/1/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/204103008/diff/1/src/builtins.cc#newcode566
src/builtins.cc:566: Handle<Object> maybe_elms =
name is confusing. It's not a MaybeObject.
TEST(HandleNull) {
CcTest::InitializeVM();
Isolate* isolate = CcTest::i_isolate();
HandleScope outer_scope(isolate);
LocalContext context;
Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate);
CHECK(!n.is_null());
}
The test case we discussed.
https://codereview.chromium.org/204103008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
