Reviewers: dcarney,
Message:
Re-trying https://codereview.chromium.org/201643003
So... I tried several variants to fix this, but without any real success.
This
version - which provides empty default implementations - seems to work
fine. At
least it does on the trybots.
I tried various versions of inline & V8_INLINE, but didn't get any of them
to
compile (on Linux) without actually providing inline methods. That is,
inline
won't help us avoid the unused default impls.
Let's briefly discuss what to do; but this is currently my best guess.
Description:
Provide default traits for PersistentValueMap
Re-try of issue 201643003. This caused linker errors on Win64, since the
linker insists on seeing the StrongMapTrait method implementations even
though they are never used. This will provide default implementations
for them.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/204343006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+186, -77 lines):
M include/v8-util.h
M test/cctest/test-api.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
