Revision: 20083
Author:   [email protected]
Date:     Wed Mar 19 15:34:17 2014 UTC
Log:      MIPS: Reland "Add out-of-line constant pool support to Arm."

Port r20053 (df27abf)

Original commit message:
This CL adds out-of-line constant pool support to Arm. A ConstantPoolBuilder
object is introduced to manage building of the ConstantPoolArray for a given
code object.

This CL depends on the following CLs landing first:
https://codereview.chromium.org/138503002/
https://codereview.chromium.org/179813005/
https://codereview.chromium.org/183553003/
https://codereview.chromium.org/183803022/
https://codereview.chromium.org/183883011/
https://codereview.chromium.org/186733006/
https://codereview.chromium.org/188063002/
https://codereview.chromium.org/190793002/
https://codereview.chromium.org/190823002/
https://codereview.chromium.org/190833002/
https://codereview.chromium.org/190883002/

BUG=
[email protected]

Review URL: https://codereview.chromium.org/204343005

Patch from Balazs Kilvady <[email protected]>.
http://code.google.com/p/v8/source/detail?r=20083

Modified:
 /branches/bleeding_edge/src/mips/assembler-mips.cc
 /branches/bleeding_edge/src/mips/assembler-mips.h

=======================================
--- /branches/bleeding_edge/src/mips/assembler-mips.cc Mon Mar 10 18:47:57 2014 UTC +++ /branches/bleeding_edge/src/mips/assembler-mips.cc Wed Mar 19 15:34:17 2014 UTC
@@ -2326,6 +2326,20 @@
       CPU::FlushICache(pc+2, sizeof(Address));
   }
 }
+
+
+MaybeObject* Assembler::AllocateConstantPool(Heap* heap) {
+  // No out-of-line constant pool support.
+  UNREACHABLE();
+  return NULL;
+}
+
+
+void Assembler::PopulateConstantPool(ConstantPoolArray* constant_pool) {
+  // No out-of-line constant pool support.
+  UNREACHABLE();
+}
+

 } }  // namespace v8::internal

=======================================
--- /branches/bleeding_edge/src/mips/assembler-mips.h Wed Mar 12 22:09:17 2014 UTC +++ /branches/bleeding_edge/src/mips/assembler-mips.h Wed Mar 19 15:34:17 2014 UTC
@@ -37,6 +37,7 @@
 #define V8_MIPS_ASSEMBLER_MIPS_H_

 #include <stdio.h>
+
 #include "assembler.h"
 #include "constants-mips.h"
 #include "serialize.h"
@@ -1005,6 +1006,12 @@

   void CheckTrampolinePool();

+  // Allocate a constant pool of the correct size for the generated code.
+  MaybeObject* AllocateConstantPool(Heap* heap);
+
+  // Generate the constant pool for the generated code.
+  void PopulateConstantPool(ConstantPoolArray* constant_pool);
+
  protected:
   // Relocation for a type-recording IC has the AST id added to it.  This
   // member variable is a way to pass the information from the call site to

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to