Revision: 20089
Author:   [email protected]
Date:     Wed Mar 19 16:27:09 2014 UTC
Log:      ARM: clean-up some stub call sequences.

BUG=
[email protected]

Review URL: https://codereview.chromium.org/203263016
http://code.google.com/p/v8/source/detail?r=20089

Modified:
 /branches/bleeding_edge/src/arm/code-stubs-arm.cc

=======================================
--- /branches/bleeding_edge/src/arm/code-stubs-arm.cc Wed Mar 19 13:39:09 2014 UTC +++ /branches/bleeding_edge/src/arm/code-stubs-arm.cc Wed Mar 19 16:27:09 2014 UTC
@@ -1575,9 +1575,9 @@
   {
     // Prevent literal pool emission before return address.
     Assembler::BlockConstPoolScope block_const_pool(masm);
-    masm->add(lr, pc, Operand(4));
+    __ add(lr, pc, Operand(4));
     __ str(lr, MemOperand(sp, 0));
-    masm->Jump(r5);
+    __ Call(r5);
   }

   __ VFPEnsureFPSCRState(r2);
@@ -1865,16 +1865,10 @@
     __ mov(ip, Operand(entry));
   }
   __ ldr(ip, MemOperand(ip));  // deref address
+  __ add(ip, ip, Operand(Code::kHeaderSize - kHeapObjectTag));

- // Branch and link to JSEntryTrampoline. We don't use the double underscore
-  // macro for the add instruction because we don't want the coverage tool
- // inserting instructions here after we read the pc. We block literal pool
-  // emission for the same reason.
-  {
-    Assembler::BlockConstPoolScope block_const_pool(masm);
-    __ mov(lr, Operand(pc));
-    masm->add(pc, ip, Operand(Code::kHeaderSize - kHeapObjectTag));
-  }
+  // Branch and link to JSEntryTrampoline.
+  __ Call(ip);

   // Unlink this frame from the handler chain.
   __ PopTryHandler();

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to