https://codereview.chromium.org/196893003/diff/1/src/x64/assembler-x64.h
File src/x64/assembler-x64.h (right):
https://codereview.chromium.org/196893003/diff/1/src/x64/assembler-x64.h#newcode1658
src/x64/assembler-x64.h:1658: arithmetic_op_32(0x03, dst, src);
The arithmetic_op and arithmetic_op_32 could be unified to
arithmetic_op(byte opcode, Register reg, Register rm_reg, int size) to
make the codes smaller. I leave it to a future CL when all the
arithmetic instructions have an instruction##p version for x32. The
current full list is at
https://github.com/fenghaitao/v8/blob/x32/tools/generate-x32-sources.py#L110.
https://codereview.chromium.org/196893003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
