On 2014/03/19 15:41:14, marja wrote:
Thanks for review!
I was also expecting this to be more difficult, but reading
Expression::IsValidLeftHandSide, it seems that the only rules are:
- property expressions are valid left hand sides
- variables (i.e., identifiers) are valid left hand sides
There is one place where variables which are not valid left hand sides are
created, in Scope::Initialize, but that's for some "convenience variable"
and
shouldn't be relevant.
(Comments NOOP, will commit the latest patch)
https://codereview.chromium.org/196343033/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/196343033/diff/1/test/cctest/test-parsing.cc#newcode2336
test/cctest/test-parsing.cc:2336: // "new foo ++",
On 2014/03/19 15:29:08, rossberg wrote:
> Can we activate this one now?
Not yet; this will start working when
ParseMemberWithNewPrefixesExpression is
moved to Base.
https://codereview.chromium.org/196343033/diff/1/test/cctest/test-parsing.cc#newcode2592
test/cctest/test-parsing.cc:2592: // TODO(marja): This doesn't work yet.
On 2014/03/19 15:29:08, rossberg wrote:
> Hm, why?
Because the check is in ParsePostfixExpression which is not yet unified,
and
PreParser::ParsePostFixExpression contains no check. In the working
cases, the
checks are in funcs which are already moved to Base.
The division point here is that this CL just adds this tracking
information,
so
funcs which are in Base already get to use it. But I didn't want to add
all
the
checks in this CL.
I'll unify ParsePostFixExpression in the next CL and enable it. (There
are a
couple of other places in parser where this check is done, and they'll
also
get
unified eventually.)
I see. Thanks.
https://codereview.chromium.org/196343033/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
