Revision: 20109
Author: [email protected]
Date: Thu Mar 20 10:12:49 2014 UTC
Log: A64: Improve the deoptimization exit code for LMathRound.
[email protected]
Review URL: https://codereview.chromium.org/203253004
http://code.google.com/p/v8/source/detail?r=20109
Modified:
/branches/bleeding_edge/src/a64/lithium-codegen-a64.cc
=======================================
--- /branches/bleeding_edge/src/a64/lithium-codegen-a64.cc Wed Mar 19
11:51:30 2014 UTC
+++ /branches/bleeding_edge/src/a64/lithium-codegen-a64.cc Thu Mar 20
10:12:49 2014 UTC
@@ -4027,7 +4027,6 @@
DoubleRegister temp1 = ToDoubleRegister(instr->temp1());
Register result = ToRegister(instr->result());
Label try_rounding;
- Label deopt;
Label done;
// Math.round() rounds to the nearest integer, with ties going towards
@@ -4049,8 +4048,7 @@
if (instr->hydrogen()->CheckFlag(HValue::kBailoutOnMinusZero)) {
__ Fmov(result, input);
- __ Cmp(result, 0);
- DeoptimizeIf(mi, instr->environment()); // [-0.5, -0.0].
+ DeoptimizeIfNegative(result, instr->environment()); // [-0.5, -0.0].
}
__ Fcmp(input, dot_five);
__ Mov(result, 1); // +0.5.
@@ -4059,9 +4057,6 @@
__ Csel(result, result, xzr, eq);
__ B(&done);
- __ Bind(&deopt);
- Deoptimize(instr->environment());
-
__ Bind(&try_rounding);
// Since we're providing a 32-bit result, we can implement
ties-to-infinity by
// adding 0.5 to the input, then taking the floor of the result. This
does not
@@ -4076,7 +4071,7 @@
// * the result is not representable using a 32-bit integer.
__ Fcmp(input, 0.0);
__ Ccmp(result, Operand(result.W(), SXTW), NoFlag, vc);
- __ B(ne, &deopt);
+ DeoptimizeIf(ne, instr->environment());
__ Bind(&done);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
