lgtm
https://codereview.chromium.org/199733012/diff/60001/tools/push-to-trunk/chromium_roll.py
File tools/push-to-trunk/chromium_roll.py (right):
https://codereview.chromium.org/199733012/diff/60001/tools/push-to-trunk/chromium_roll.py#newcode3
tools/push-to-trunk/chromium_roll.py:3: # Redistribution and use in
source and binary forms, with or without
use the new short license header for new files
https://codereview.chromium.org/199733012/diff/60001/tools/push-to-trunk/chromium_roll.py#newcode71
tools/push-to-trunk/chromium_roll.py:71: "this script to automate
creation of the roll CL? If yes, enter the "
This prompt doesn't make sense any more. Suggestion: turn the loop into
'while not self["chrome_path"]:' and update the printed text.
https://codereview.chromium.org/199733012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
