Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
Fix polymorphic hydrogen handling of SLOPPY_ARGUMENTS_ELEMENTS
BUG=chromium:354391
LOG=y
[email protected]
Please review this at https://codereview.chromium.org/206073008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+26, -0 lines):
M src/hydrogen.cc
A test/mjsunit/regress/regress-crbug-354391.js
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index
282fae7800bab93132c198f0c338762c2cce7b74..891c714e769181f94b4f13a9c8e71f2908f4a4f4
100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -6395,6 +6395,11 @@ HValue*
HOptimizedGraphBuilder::HandlePolymorphicElementAccess(
elements_kind != GetInitialFastElementsKind()) {
possible_transitioned_maps.Add(map);
}
+ if (elements_kind == SLOPPY_ARGUMENTS_ELEMENTS) {
+ HInstruction* result = BuildKeyedGeneric(access_type, object, key,
val);
+ *has_side_effects = result->HasObservableSideEffects();
+ return AddInstruction(result);
+ }
}
// Get transition target for each map (NULL == no transition).
for (int i = 0; i < maps->length(); ++i) {
Index: test/mjsunit/regress/regress-crbug-354391.js
diff --git a/test/mjsunit/regress/regress-crbug-354391.js
b/test/mjsunit/regress/regress-crbug-354391.js
new file mode 100644
index
0000000000000000000000000000000000000000..e652bd3d0f2b32cd5e0b6a38b5fa0ce9599cfdef
--- /dev/null
+++ b/test/mjsunit/regress/regress-crbug-354391.js
@@ -0,0 +1,21 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function load(a, i) {
+ return a[i];
+}
+
+function f2(a, b, c, d, index) {
+ return load(arguments, index);
+}
+
+f2(1, 2, 3, 4, "foo");
+f2(1, 2, 3, 4, "foo");
+load([11, 22, 33], 0);
+assertEquals(11, f2(11, 22, 33, 44, 0));
+
+%OptimizeFunctionOnNextCall(load);
+assertEquals(11, f2(11, 22, 33, 44, 0));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
