Revision: 20137
Author: [email protected]
Date: Thu Mar 20 16:25:24 2014 UTC
Log: Fix polymorphic hydrogen handling of SLOPPY_ARGUMENTS_ELEMENTS
BUG=chromium:354391
LOG=y
[email protected]
Review URL: https://codereview.chromium.org/206073008
http://code.google.com/p/v8/source/detail?r=20137
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-crbug-354391.js
Modified:
/branches/bleeding_edge/src/hydrogen.cc
=======================================
--- /dev/null
+++ /branches/bleeding_edge/test/mjsunit/regress/regress-crbug-354391.js
Thu Mar 20 16:25:24 2014 UTC
@@ -0,0 +1,21 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Flags: --allow-natives-syntax
+
+function load(a, i) {
+ return a[i];
+}
+
+function f2(a, b, c, d, index) {
+ return load(arguments, index);
+}
+
+f2(1, 2, 3, 4, "foo");
+f2(1, 2, 3, 4, "foo");
+load([11, 22, 33], 0);
+assertEquals(11, f2(11, 22, 33, 44, 0));
+
+%OptimizeFunctionOnNextCall(load);
+assertEquals(11, f2(11, 22, 33, 44, 0));
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Thu Mar 20 12:34:44 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen.cc Thu Mar 20 16:25:24 2014 UTC
@@ -6395,6 +6395,11 @@
elements_kind != GetInitialFastElementsKind()) {
possible_transitioned_maps.Add(map);
}
+ if (elements_kind == SLOPPY_ARGUMENTS_ELEMENTS) {
+ HInstruction* result = BuildKeyedGeneric(access_type, object, key,
val);
+ *has_side_effects = result->HasObservableSideEffects();
+ return AddInstruction(result);
+ }
}
// Get transition target for each map (NULL == no transition).
for (int i = 0; i < maps->length(); ++i) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
