LGTM with nits.
https://codereview.chromium.org/207633003/diff/1/src/parser.h
File src/parser.h (right):
https://codereview.chromium.org/207633003/diff/1/src/parser.h#newcode478
src/parser.h:478: void MaybePushPropertyName(FuncNameInferrer* fni,
Expression* expression);
nit: Can we call this PushPropertyOrLiteralName, because "maybe" sounds
misleading in the sense that it suggests there are cases where nothing
is pushed.
https://codereview.chromium.org/207633003/diff/1/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/207633003/diff/1/src/preparser.h#newcode878
src/preparser.h:878: ASSERT(false);
nit: s/ASSERT(false)/UNREACHABLE/ here and above.
https://codereview.chromium.org/207633003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
