LGTM.
https://codereview.chromium.org/197233011/diff/1/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):
https://codereview.chromium.org/197233011/diff/1/src/ia32/macro-assembler-ia32.cc#newcode2850
src/ia32/macro-assembler-ia32.cc:2850: void
MacroAssembler::Move(Register dst, Immediate imm) {
As discussed offline: This method is a duplication of
MacroAssembler::Set(). I think we should unify the two. Even though
Set() was here before, I prefer the name Move(). But that is something
for a follow-up CL.
https://codereview.chromium.org/197233011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
