Revision: 20169
Author: [email protected]
Date: Fri Mar 21 15:08:50 2014 UTC
Log: A64: Now that we have veneers, fix a couple of branches to
directly jump to their target.
[email protected]
Review URL: https://codereview.chromium.org/207883002
http://code.google.com/p/v8/source/detail?r=20169
Modified:
/branches/bleeding_edge/src/arm64/regexp-macro-assembler-arm64.cc
=======================================
--- /branches/bleeding_edge/src/arm64/regexp-macro-assembler-arm64.cc Fri
Mar 21 09:28:26 2014 UTC
+++ /branches/bleeding_edge/src/arm64/regexp-macro-assembler-arm64.cc Fri
Mar 21 15:08:50 2014 UTC
@@ -1481,12 +1481,7 @@
if (to == NULL) {
to = &backtrack_label_;
}
- // TODO(ulan): do direct jump when jump distance is known and fits in
imm19.
- Condition inverted_condition = InvertCondition(condition);
- Label no_branch;
- __ B(inverted_condition, &no_branch);
- __ B(to);
- __ Bind(&no_branch);
+ __ B(condition, to);
}
void RegExpMacroAssemblerARM64::CompareAndBranchOrBacktrack(Register reg,
@@ -1497,15 +1492,11 @@
if (to == NULL) {
to = &backtrack_label_;
}
- // TODO(ulan): do direct jump when jump distance is known and fits in
imm19.
- Label no_branch;
if (condition == eq) {
- __ Cbnz(reg, &no_branch);
+ __ Cbz(reg, to);
} else {
- __ Cbz(reg, &no_branch);
+ __ Cbnz(reg, to);
}
- __ B(to);
- __ Bind(&no_branch);
} else {
__ Cmp(reg, immediate);
BranchOrBacktrack(condition, to);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
