Reviewers: Yang,
Message:
PTAL.
Description:
Remove an unused isolate_ field from BacktrackStack.
Found by Nico Weber with -Wunused-private-field
Please review this at https://codereview.chromium.org/208613002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -3 lines):
M src/interpreter-irregexp.cc
Index: src/interpreter-irregexp.cc
diff --git a/src/interpreter-irregexp.cc b/src/interpreter-irregexp.cc
index
ccabfd10dfdacbbe1f1b78e184b9b03b9b7e6a61..de54d0c426796f238c3d0b3c443e0f6de2bce498
100644
--- a/src/interpreter-irregexp.cc
+++ b/src/interpreter-irregexp.cc
@@ -158,7 +158,7 @@ static int32_t Load16Aligned(const byte* pc) {
// matching terminates.
class BacktrackStack {
public:
- explicit BacktrackStack(Isolate* isolate) : isolate_(isolate) {
+ explicit BacktrackStack() {
data_ = NewArray<int>(kBacktrackStackSize);
}
@@ -174,7 +174,6 @@ class BacktrackStack {
static const int kBacktrackStackSize = 10000;
int* data_;
- Isolate* isolate_;
DISALLOW_COPY_AND_ASSIGN(BacktrackStack);
};
@@ -191,7 +190,7 @@ static RegExpImpl::IrregexpResult RawMatch(Isolate*
isolate,
// BacktrackStack ensures that the memory allocated for the backtracking
stack
// is returned to the system or cached if there is no stack being cached
at
// the moment.
- BacktrackStack backtrack_stack(isolate);
+ BacktrackStack backtrack_stack;
int* backtrack_stack_base = backtrack_stack.data();
int* backtrack_sp = backtrack_stack_base;
int backtrack_stack_space = backtrack_stack.max_size();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
