On 2014/03/21 17:22:47, Toon Verwaest wrote:
Sure, the optimization I'm suggesting isn't there yet. It's just "the
right
thing to do".
Right. I would say this patch could also be generalized to support the
case of writable global objects with constant properties. However, outside
Math.*
there isn't any interesting uses afaik.
Your implementation is not only pretty hacky, but also wrong. E.g., you
only
deoptimize while overwriting the property through the runtime. An
assignment
via
IC or Crankshaft would not trap, and would lead to wrong semantics.
I think doing it with inserted guards would negate all or a lot of the
performance gained.
Can you explain how this is different from an assignment to the array or the
object prototype
elements which is also only checked in runtime to deoptimize the
kElementsCantBeAddedGroup?
https://codereview.chromium.org/198533007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
