Thanks a lot for the comments.Please see the new patch.
https://codereview.chromium.org/179773002/diff/110001/src/x64/lithium-gap-resolver-x64.cc
File src/x64/lithium-gap-resolver-x64.cc (right):
https://codereview.chromium.org/179773002/diff/110001/src/x64/lithium-gap-resolver-x64.cc#newcode223
src/x64/lithium-gap-resolver-x64.cc:223: if
(cgen_->IsSmiConstant(constant_source)) {
On 2014/03/21 12:36:36, danno wrote:
Just like you added stack slot support elsewhere, the same must be
done for
split ranges in the gap resolver that happen to end up in a stack
slot. It may
be tricky to construct a test case, but certainly doable (changing
HConstant::EmitAtUses to always return false will certainly make it
easier).
Yes, that is possible. Actually the "movp" has already done the sign
extension to store the 32bit imm into 64bit stack slot. The original
comment is misleading, so I refine it and some other comments. Thanks a
lot.
https://codereview.chromium.org/179773002/diff/110001/src/x64/lithium-gap-resolver-x64.cc#newcode223
src/x64/lithium-gap-resolver-x64.cc:223: if
(cgen_->IsSmiConstant(constant_source)) {
On 2014/03/21 12:36:36, danno wrote:
Just like you added stack slot support elsewhere, the same must be
done for
split ranges in the gap resolver that happen to end up in a stack
slot. It may
be tricky to construct a test case, but certainly doable (changing
HConstant::EmitAtUses to always return false will certainly make it
easier).
Done.
https://codereview.chromium.org/179773002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
