Revision: 20188
Author: [email protected]
Date: Mon Mar 24 12:13:58 2014 UTC
Log: Fix component build some more.
Not V8_EXPORTing ScriptCompiler::Source got rid of the last errors. This
fixes
the new ones created by it. V8_INLINEing these funcs makes sense anyway.
In addition, added declared-private-and-unimplemented assignment operators
which were accidentally omitted.
[email protected]
BUG=
Review URL: https://codereview.chromium.org/209873004
http://code.google.com/p/v8/source/detail?r=20188
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/src/api.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Mon Mar 24 10:07:15 2014 UTC
+++ /branches/bleeding_edge/include/v8.h Mon Mar 24 12:13:58 2014 UTC
@@ -1120,6 +1120,7 @@
private:
// Prevent copying. Not implemented.
CachedData(const CachedData&);
+ CachedData& operator=(const CachedData&);
};
/**
@@ -1129,20 +1130,22 @@
class Source {
public:
// Source takes ownership of CachedData.
- Source(Local<String> source_string, const ScriptOrigin& origin,
+ V8_INLINE Source(Local<String> source_string, const ScriptOrigin&
origin,
CachedData* cached_data = NULL);
- Source(Local<String> source_string, CachedData* cached_data = NULL);
- ~Source();
+ V8_INLINE Source(Local<String> source_string,
+ CachedData* cached_data = NULL);
+ V8_INLINE ~Source();
// Ownership of the CachedData or its buffers is *not* transferred to
the
// caller. The CachedData object is alive as long as the Source object
is
// alive.
- const CachedData* GetCachedData() const;
+ V8_INLINE const CachedData* GetCachedData() const;
private:
friend class ScriptCompiler;
// Prevent copying. Not implemented.
Source(const Source&);
+ Source& operator=(const Source&);
Local<String> source_string;
@@ -6071,6 +6074,32 @@
Handle<Boolean> ScriptOrigin::ResourceIsSharedCrossOrigin() const {
return resource_is_shared_cross_origin_;
}
+
+
+ScriptCompiler::Source::Source(Local<String> string, const ScriptOrigin&
origin,
+ CachedData* data)
+ : source_string(string),
+ resource_name(origin.ResourceName()),
+ resource_line_offset(origin.ResourceLineOffset()),
+ resource_column_offset(origin.ResourceColumnOffset()),
+
resource_is_shared_cross_origin(origin.ResourceIsSharedCrossOrigin()),
+ cached_data(data) {}
+
+
+ScriptCompiler::Source::Source(Local<String> string,
+ CachedData* data)
+ : source_string(string), cached_data(data) {}
+
+
+ScriptCompiler::Source::~Source() {
+ delete cached_data;
+}
+
+
+const ScriptCompiler::CachedData* ScriptCompiler::Source::GetCachedData()
+ const {
+ return cached_data;
+}
Handle<Boolean> Boolean::New(Isolate* isolate, bool value) {
=======================================
--- /branches/bleeding_edge/src/api.cc Mon Mar 24 10:07:15 2014 UTC
+++ /branches/bleeding_edge/src/api.cc Mon Mar 24 12:13:58 2014 UTC
@@ -1622,32 +1622,6 @@
delete[] data;
}
}
-
-
-ScriptCompiler::Source::Source(Local<String> string, const ScriptOrigin&
origin,
- CachedData* data)
- : source_string(string),
- resource_name(origin.ResourceName()),
- resource_line_offset(origin.ResourceLineOffset()),
- resource_column_offset(origin.ResourceColumnOffset()),
-
resource_is_shared_cross_origin(origin.ResourceIsSharedCrossOrigin()),
- cached_data(data) {}
-
-
-ScriptCompiler::Source::Source(Local<String> string,
- CachedData* data)
- : source_string(string), cached_data(data) {}
-
-
-ScriptCompiler::Source::~Source() {
- delete cached_data;
-}
-
-
-const ScriptCompiler::CachedData* ScriptCompiler::Source::GetCachedData()
- const {
- return cached_data;
-}
Local<Script> UnboundScript::BindToCurrentContext() {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
