Reviewers: ulan,
Message:
Ulan: Unfortunately your suggestion of simply not marking heap entries in
the
Constant Pool didn't work because the VerifyMarking object visitor would
complain that some object's weren't marked. I've changed approach and now
simply mark whether the constant pool is for optimized code and do the
appropriate checks in object visitor. PTAL.
Description:
Ensure that we don't mark weak heap references in the constant pool array.
Some heap pointer's embedded in optimized code are considered weak. Ensure
that we don't mark them during GC of the ConstantPoolArray. Also, embed
length metadata in a bitfield, reducing the ConstantPoolArray header size
from
five words to two.
Please review this at https://codereview.chromium.org/209473006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+92, -55 lines):
M src/arm/assembler-arm.h
M src/arm/assembler-arm.cc
M src/factory.h
M src/factory.cc
M src/heap.h
M src/heap.cc
M src/objects-inl.h
M src/objects-visiting-inl.h
M src/objects.h
M test/cctest/test-constantpool.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
