lgtm with nits:
https://codereview.chromium.org/207613005/diff/1/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/207613005/diff/1/src/ast.cc#newcode1182
src/ast.cc:1182: return res;
As the allocation size is small and you are not going to check the
result this looks like a spurious change.
https://codereview.chromium.org/207613005/diff/1/src/json-parser.h
File src/json-parser.h (right):
https://codereview.chromium.org/207613005/diff/1/src/json-parser.h#newcode798
src/json-parser.h:798: RETURN_IF_EMPTY_HANDLE_VALUE(isolate(), result,
Handle<String>());
Do we really need both ASSERT and RETURN_IF_EMPTY_HANDLE_VALUE here?
https://codereview.chromium.org/207613005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/207613005/diff/1/src/runtime.cc#newcode4112
src/runtime.cc:4112:
ASSERT(!answer.is_null()); ?
https://codereview.chromium.org/207613005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
