>From some quick profiling, it appears that the test generates so many unresolved branches (forward branches) that it puts a lot fo pressure on `std::multimap<int, FarBranchInfo> unresolved_branches_`. Without the patch the conditional branches are resolved locally and the unconditional branch does not require an entry in unresolved_branches_. So I think it is not a correctness issue. I could spend some time looking at solutions to improve that (maybe a custom allocator for the multimap?).
On Monday, March 24, 2014 3:59:55 PM UTC, [email protected] wrote: > > lgtm > > Alexandre, any idea why this regressed performance? > > > https://codereview.chromium.org/209333004/ > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
