Should be fixed now. Thanks!
https://codereview.chromium.org/201573011/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/201573011/diff/1/src/x64/lithium-codegen-x64.cc#newcode2927
src/x64/lithium-codegen-x64.cc:2927: __ Abort(kInvalidArgumentIndex);
On 2014/03/24 15:23:28, Igor Sheludko wrote:
Abort() calls runtime which requires context to be in rsi but this
instruction
does not handle context. Most likely it will crash if ever hits the
Abort()
case. I'm not fully sure but probably you should use int3() here.
Done.
https://codereview.chromium.org/201573011/diff/1/test/mjsunit/regress/regress-355486.js
File test/mjsunit/regress/regress-355486.js (right):
https://codereview.chromium.org/201573011/diff/1/test/mjsunit/regress/regress-355486.js#newcode7
test/mjsunit/regress/regress-355486.js:7: function __f_17() {
On 2014/03/24 15:33:31, Igor Sheludko wrote:
Please rename identifiers without underscores and numbers.
Done.
https://codereview.chromium.org/201573011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
