lgtm
https://codereview.chromium.org/210253002/diff/1/src/arm64/lithium-arm64.cc
File src/arm64/lithium-arm64.cc (right):
https://codereview.chromium.org/210253002/diff/1/src/arm64/lithium-arm64.cc#newcode1914
src/arm64/lithium-arm64.cc:1914: !((constant >= -1) && (constant <= 2));
Since (constant >= -1) && (constant <= 2) used twice consider giving it
a name like small_constant to improve readability.
https://codereview.chromium.org/210253002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
