Revision: 20227
Author: [email protected]
Date: Tue Mar 25 09:29:48 2014 UTC
Log: Reland of "FastElementsAccessor::SetLengthWithoutNormalize()
handlified."
[email protected]
Review URL: https://codereview.chromium.org/210563003
http://code.google.com/p/v8/source/detail?r=20227
Modified:
/branches/bleeding_edge/src/elements.cc
=======================================
--- /branches/bleeding_edge/src/elements.cc Mon Mar 24 19:12:43 2014 UTC
+++ /branches/bleeding_edge/src/elements.cc Tue Mar 25 09:29:48 2014 UTC
@@ -783,6 +783,16 @@
UNIMPLEMENTED();
return obj;
}
+
+ // TODO(ishell): Temporary wrapper until handlified.
+ MUST_USE_RESULT static Handle<Object> SetFastElementsCapacityAndLength(
+ Handle<JSObject> obj,
+ int capacity,
+ int length) {
+ CALL_HEAP_FUNCTION(obj->GetIsolate(),
+ SetFastElementsCapacityAndLength(*obj, capacity,
length),
+ Object);
+ }
MUST_USE_RESULT virtual Handle<Object> Delete(
Handle<JSObject> obj,
@@ -978,28 +988,28 @@
// Adjusts the length of the fast backing store or returns the new
length or
// undefined in case conversion to a slow backing store should be
performed.
- static MaybeObject* SetLengthWithoutNormalize(FixedArrayBase*
backing_store,
- JSArray* array,
- Object* length_object,
- uint32_t length) {
+ static Handle<Object> SetLengthWithoutNormalize(
+ Handle<FixedArrayBase> backing_store,
+ Handle<JSArray> array,
+ Handle<Object> length_object,
+ uint32_t length) {
+ Isolate* isolate = array->GetIsolate();
uint32_t old_capacity = backing_store->length();
- Object* old_length = array->length();
+ Handle<Object> old_length(array->length(), isolate);
bool same_or_smaller_size = old_length->IsSmi() &&
- static_cast<uint32_t>(Smi::cast(old_length)->value()) >= length;
+ static_cast<uint32_t>(Handle<Smi>::cast(old_length)->value()) >=
length;
ElementsKind kind = array->GetElementsKind();
if (!same_or_smaller_size && IsFastElementsKind(kind) &&
!IsFastHoleyElementsKind(kind)) {
kind = GetHoleyElementsKind(kind);
- MaybeObject* maybe_obj = array->TransitionElementsKind(kind);
- if (maybe_obj->IsFailure()) return maybe_obj;
+ JSObject::TransitionElementsKind(array, kind);
}
// Check whether the backing store should be shrunk.
if (length <= old_capacity) {
if (array->HasFastSmiOrObjectElements()) {
- MaybeObject* maybe_obj = array->EnsureWritableFastElements();
- if (!maybe_obj->To(&backing_store)) return maybe_obj;
+ backing_store = JSObject::EnsureWritableFastElements(array);
}
if (2 * length <= old_capacity) {
// If more than half the elements won't be used, trim the array.
@@ -1016,7 +1026,7 @@
// Otherwise, fill the unused tail with holes.
int old_length = FastD2IChecked(array->length()->Number());
for (int i = length; i < old_length; i++) {
- BackingStore::cast(backing_store)->set_the_hole(i);
+ Handle<BackingStore>::cast(backing_store)->set_the_hole(i);
}
}
return length_object;
@@ -1026,27 +1036,14 @@
uint32_t min = JSObject::NewElementsCapacity(old_capacity);
uint32_t new_capacity = length > min ? length : min;
if (!array->ShouldConvertToSlowElements(new_capacity)) {
- MaybeObject* result = FastElementsAccessorSubclass::
+ FastElementsAccessorSubclass::
SetFastElementsCapacityAndLength(array, new_capacity, length);
- if (result->IsFailure()) return result;
array->ValidateElements();
return length_object;
}
// Request conversion to slow elements.
- return array->GetHeap()->undefined_value();
- }
-
- // TODO(ishell): Temporary wrapper until handlified.
- static Handle<Object> SetLengthWithoutNormalize(
- Handle<FixedArrayBase> backing_store,
- Handle<JSArray> array,
- Handle<Object> length_object,
- uint32_t length) {
- CALL_HEAP_FUNCTION(array->GetIsolate(),
- SetLengthWithoutNormalize(
- *backing_store, *array, *length_object, length),
- Object);
+ return isolate->factory()->undefined_value();
}
static Handle<Object> DeleteCommon(Handle<JSObject> obj,
@@ -1244,6 +1241,16 @@
length,
set_capacity_mode);
}
+
+ // TODO(ishell): Temporary wrapper until handlified.
+ static Handle<Object> SetFastElementsCapacityAndLength(
+ Handle<JSObject> obj,
+ int capacity,
+ int length) {
+ CALL_HEAP_FUNCTION(obj->GetIsolate(),
+ SetFastElementsCapacityAndLength(*obj, capacity,
length),
+ Object);
+ }
};
@@ -1313,6 +1320,16 @@
return obj->SetFastDoubleElementsCapacityAndLength(capacity,
length);
}
+
+ // TODO(ishell): Temporary wrapper until handlified.
+ static Handle<Object> SetFastElementsCapacityAndLength(
+ Handle<JSObject> obj,
+ int capacity,
+ int length) {
+ CALL_HEAP_FUNCTION(obj->GetIsolate(),
+ SetFastElementsCapacityAndLength(*obj, capacity,
length),
+ Object);
+ }
protected:
static MaybeObject* CopyElementsImpl(FixedArrayBase* from,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
