Reviewers: Jakob,
Message:
PTAL. This fixes the new windows nosnap shared library builder. In a future
CL,
we could also make these file real temp files, so that there won't be any
path
issues.
Description:
Fix test serialization path for windows.
This work-around takes into account that MSVS doesn't build to "out".
BUG=
Please review this at https://codereview.chromium.org/202923003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -1 lines):
M test/cctest/testcfg.py
Index: test/cctest/testcfg.py
diff --git a/test/cctest/testcfg.py b/test/cctest/testcfg.py
index
4ab5ab5b7d88ad1e37524da7a08e67a408926c7d..bd93450a97e87e3b184174932fb56cd832dbdfd4
100644
--- a/test/cctest/testcfg.py
+++ b/test/cctest/testcfg.py
@@ -38,8 +38,12 @@ class CcTestSuite(testsuite.TestSuite):
def __init__(self, name, root):
super(CcTestSuite, self).__init__(name, root)
+ if utils.IsWindows():
+ build_dir = "build"
+ else:
+ build_dir = "out"
self.serdes_dir = os.path.normpath(
- os.path.join(root, "..", "..", "out", ".serdes"))
+ os.path.join(root, "..", "..", build_dir, ".serdes"))
if os.path.exists(self.serdes_dir):
shutil.rmtree(self.serdes_dir, True)
os.makedirs(self.serdes_dir)
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
