Reviewers: rossberg,
Message:
PTAL
This fixes webexposed/ layout tests in blink, so it should be landed and
rolled
before https://codereview.chromium.org/209853010/ lands.
Description:
Don't enum Promise constructor.
Promise should not be enumerable in the global object.
BUG=352597
[email protected]
Please review this at https://codereview.chromium.org/211943004/
SVN Base: https://chromium.googlesource.com/external/v8.git@master
Affected files (+5, -1 lines):
M src/promise.js
Index: src/promise.js
diff --git a/src/promise.js b/src/promise.js
index
23e51259a36c43849002990ea2b3ebbb3c5c0105..a22c46e4744b9746041c9e89ec14647be9e62bcc
100644
--- a/src/promise.js
+++ b/src/promise.js
@@ -308,7 +308,11 @@ function PromiseOne(values) {
function SetUpPromise() {
%CheckIsBootstrapping()
var global_receiver = %GlobalReceiver(global);
- global_receiver.Promise = $Promise;
+ $Object.defineProperty(global_receiver, 'Promise', {
+ value: $Promise,
+ writable: true,
+ configurable: true
+ });
InstallFunctions($Promise, DONT_ENUM, [
"defer", PromiseDeferred,
"accept", PromiseResolved,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
