I am not yet entirely convinced that this change actually improves the
situation
overall. Admittedly it removes one of the "if (do_something_different)
{ ... }"
branches in the lithium code generator. But that comes at the expense of
duplicating 40 lines of code in each code generator. And they are separated
far
enough that I can totally imagine my stupid-future-self updating one
instance
but not the other.
I do +1 the part that introduces a separate LInstruction for the flooring
division, this makes the distinction in semantics clear in the lithium
graph.
I would be totally fine with this change if the common code in the generator
would still be shared. For example by using a helper function or support
from
the macro assembler, as you mentioned yourself in the CL description.
https://codereview.chromium.org/212703002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
