If the comments do not make sense then lgtm.
https://codereview.chromium.org/210953005/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/210953005/diff/1/src/bootstrapper.cc#newcode1941
src/bootstrapper.cc:1941: Handle<JSFunction>::cast(Object::GetProperty(
We don't need all the checks performed by Runtime::GetObjectProperty()
for global objects. Right?
https://codereview.chromium.org/210953005/diff/1/src/execution.cc
File src/execution.cc (right):
https://codereview.chromium.org/210953005/diff/1/src/execution.cc#newcode786
src/execution.cc:786: Handle<Object> char_at = Object::GetProperty(
We don't need all the checks done by Runtime::GetObjectProperty() for js
builtins object. Right?
https://codereview.chromium.org/210953005/diff/1/src/json-stringifier.h
File src/json-stringifier.h (right):
https://codereview.chromium.org/210953005/diff/1/src/json-stringifier.h#newcode660
src/json-stringifier.h:660: for (int i = 0; i <
map->NumberOfOwnDescriptors(); i++) {
Shouldn't we create a HandleScope here inside the loop?
https://codereview.chromium.org/210953005/diff/1/src/json-stringifier.h#newcode687
src/json-stringifier.h:687: for (int i = 0; i < contents->length(); i++)
{
And here?
https://codereview.chromium.org/210953005/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/210953005/diff/1/src/objects.cc#newcode3606
src/objects.cc:3606: Handle<Object> configurable =
Object::GetProperty(desc, configurable_name);
Is it possible to get undefined or null as a desc here? If not is it
worth ASSERTing about that?
https://codereview.chromium.org/210953005/diff/1/src/objects.cc#newcode3741
src/objects.cc:3741: RETURN_IF_EMPTY_HANDLE_VALUE(isolate, setter,
NONE);
Add two spaces in front of the line.
https://codereview.chromium.org/210953005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
