Reviewers: Yang,
Message:
yangguo, again a tiny cleanup CL, ptal.
Description:
Cleanup scanner character streams.
- GenericStringUtf16CharacterStream::start_position_ was unused.
- GenericStringUtf16CharacterStream inherits from
BufferedUtf16CharacterStream,
so no need to initialize buffer_cursor_ and buffer_end_ twice (this makes it
clearer which class in the inheritance chain takes care of which variables).
[email protected]
BUG=
Please review this at https://codereview.chromium.org/216523004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -3 lines):
M src/scanner-character-streams.h
M src/scanner-character-streams.cc
Index: src/scanner-character-streams.cc
diff --git a/src/scanner-character-streams.cc
b/src/scanner-character-streams.cc
index
cbef3f95bb7086b4d411c8f5dc08c98f730153db..201b597fb72d92365e17a1f3fb7e5e1866c67e15
100644
--- a/src/scanner-character-streams.cc
+++ b/src/scanner-character-streams.cc
@@ -126,8 +126,6 @@
GenericStringUtf16CharacterStream::GenericStringUtf16CharacterStream(
: string_(data),
length_(end_position) {
ASSERT(end_position >= start_position);
- buffer_cursor_ = buffer_;
- buffer_end_ = buffer_;
pos_ = start_position;
}
Index: src/scanner-character-streams.h
diff --git a/src/scanner-character-streams.h
b/src/scanner-character-streams.h
index
319ee8fc1c587f82487b8e402250914adb2dcee2..80ef9bd525e6f95b5f2ae06ca9997793f1ef9635
100644
--- a/src/scanner-character-streams.h
+++ b/src/scanner-character-streams.h
@@ -72,7 +72,6 @@ class GenericStringUtf16CharacterStream: public
BufferedUtf16CharacterStream {
virtual unsigned FillBuffer(unsigned position, unsigned length);
Handle<String> string_;
- unsigned start_position_;
unsigned length_;
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
