LGTM, but I'll forward this to Jarin for in-depth review.
https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc
File src/platform-win32.cc (right):
https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#newcode1426
src/platform-win32.cc:1426: static void SetCurThreadName(const char*
name) {
Nit: Use SetCurrentThreadName()
https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#newcode1437
src/platform-win32.cc:1437: {
Nit: no need for a {}-block here.
https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#newcode1440
src/platform-win32.cc:1440: info.dwThreadID = (DWORD)-1;
Use static_cast<DWORD>(-1)
https://codereview.chromium.org/206253003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
