https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc
File src/platform-win32.cc (right):
https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#newcode1426
src/platform-win32.cc:1426: static void SetCurThreadName(const char*
name) {
On 2014/03/31 06:57:02, Benedikt Meurer wrote:
Nit: Use SetCurrentThreadName()
How about taking the code from Chromium? See
https://code.google.com/p/chromium/codesearch#chromium/src/base/threading/platform_thread_win.cc
https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#newcode1427
src/platform-win32.cc:1427: // Reference:
http://www.codeproject.com/KB/threads/Name_threads_in_debugger.aspx
I would prefer to link Microsoft rather than codeproject.com
(http://msdn.microsoft.com/en-us/library/xcb2z8hs.aspx).
https://codereview.chromium.org/206253003/diff/40001/src/platform-win32.cc#newcode1447
src/platform-win32.cc:1447: sizeof(info)/sizeof(DWORD),
reinterpret_cast<ULONG_PTR*>(&info));
The Microsoft article says the third arg should be
sizeof(info)/sizeof(ULONG_PTR). Confusingly, the Chromium source says
sizeof(info)/sizeof(DWORD). Personally, I would trust the Microsoft
article (and suggest a fix to Chromium).
https://codereview.chromium.org/206253003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
