LGTM with one suggestion.

https://codereview.chromium.org/218993011/diff/1/src/objects.cc
File src/objects.cc (left):

https://codereview.chromium.org/218993011/diff/1/src/objects.cc#oldcode13877
src/objects.cc:13877: string_ = string_->TryFlattenGetString();
I am not an expert on this, but doesn't it still make sense to try to
flatten any cons-string before attempting to internalize?

https://codereview.chromium.org/218993011/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to