Revision: 20393
Author: [email protected]
Date: Tue Apr 1 11:23:23 2014 UTC
Log: Remove debugger_auto_break flag
The flag was introduced to support console debugger in Chrome. That
debugger was replaced by DevTools long time ago and the flag is always true
now.
BUG=None
LOG=Y
[email protected]
Review URL: https://codereview.chromium.org/220743003
http://code.google.com/p/v8/source/detail?r=20393
Modified:
/branches/bleeding_edge/include/v8-debug.h
/branches/bleeding_edge/src/execution.cc
/branches/bleeding_edge/src/flag-definitions.h
/branches/bleeding_edge/test/cctest/test-debug.cc
=======================================
--- /branches/bleeding_edge/include/v8-debug.h Thu Mar 27 12:15:14 2014 UTC
+++ /branches/bleeding_edge/include/v8-debug.h Tue Apr 1 11:23:23 2014 UTC
@@ -290,7 +290,7 @@
*
* Generally when message arrives V8 may be in one of 3 states:
* 1. V8 is running script; V8 will automatically interrupt and process
all
- * pending messages (however auto_break flag should be enabled);
+ * pending messages;
* 2. V8 is suspended on debug breakpoint; in this state V8 is dedicated
* to reading and processing debug messages;
* 3. V8 is not running at all or has called some long-working C++
function;
=======================================
--- /branches/bleeding_edge/src/execution.cc Mon Mar 31 12:01:02 2014 UTC
+++ /branches/bleeding_edge/src/execution.cc Tue Apr 1 11:23:23 2014 UTC
@@ -519,11 +519,9 @@
void StackGuard::DebugCommand() {
- if (FLAG_debugger_auto_break) {
- ExecutionAccess access(isolate_);
- thread_local_.interrupt_flags_ |= DEBUGCOMMAND;
- set_interrupt_limits(access);
- }
+ ExecutionAccess access(isolate_);
+ thread_local_.interrupt_flags_ |= DEBUGCOMMAND;
+ set_interrupt_limits(access);
}
#endif
=======================================
--- /branches/bleeding_edge/src/flag-definitions.h Mon Mar 31 12:40:32 2014
UTC
+++ /branches/bleeding_edge/src/flag-definitions.h Tue Apr 1 11:23:23 2014
UTC
@@ -471,9 +471,6 @@
"trace out-of-bounds accesses to all arrays")
DEFINE_implication(trace_array_abuse, trace_js_array_abuse)
DEFINE_implication(trace_array_abuse, trace_external_array_abuse)
-DEFINE_bool(debugger_auto_break, true,
- "automatically set the debug break flag when debugger commands
are "
- "in the queue")
DEFINE_bool(enable_liveedit, true, "enable liveedit experimental feature")
DEFINE_bool(hard_abort, true, "abort by crashing")
=======================================
--- /branches/bleeding_edge/test/cctest/test-debug.cc Wed Mar 19 13:24:13
2014 UTC
+++ /branches/bleeding_edge/test/cctest/test-debug.cc Tue Apr 1 11:23:23
2014 UTC
@@ -5409,8 +5409,6 @@
void TestRecursiveBreakpointsGeneric(bool global_evaluate) {
- i::FLAG_debugger_auto_break = true;
-
BreakpointsDebuggerThread breakpoints_debugger_thread(global_evaluate);
BreakpointsV8Thread breakpoints_v8_thread;
@@ -5881,7 +5879,6 @@
TEST(DebuggerHostDispatch) {
HostDispatchDebuggerThread host_dispatch_debugger_thread;
HostDispatchV8Thread host_dispatch_v8_thread;
- i::FLAG_debugger_auto_break = true;
// Create a V8 environment
Barriers stack_allocated_host_dispatch_barriers;
@@ -5948,8 +5945,6 @@
DebugMessageDispatchDebuggerThread
debug_message_dispatch_debugger_thread;
DebugMessageDispatchV8Thread debug_message_dispatch_v8_thread;
- i::FLAG_debugger_auto_break = true;
-
// Create a V8 environment
Barriers stack_allocated_debug_message_dispatch_barriers;
debug_message_dispatch_barriers =
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
