Reviewers: jarin,
Message:
PTAL.
Description:
Fix "make arm asan=$CLANG"
Bonus cleanup: remove a few duplicate compiler flags
Please review this at https://codereview.chromium.org/220883003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -7 lines):
M Makefile
M build/toolchain.gypi
Index: Makefile
diff --git a/Makefile b/Makefile
index
cdf5d74832fa79bbdc4a5b4abde0faedc8cfa8e2..ff01c7d779ab5f863bea679078425db0f0b72574
100644
--- a/Makefile
+++ b/Makefile
@@ -140,9 +140,9 @@ endif
# asan=/path/to/clang++
ifneq ($(strip $(asan)),)
GYPFLAGS += -Dasan=1
- export CXX="$(asan)"
- export CXX_host="$(asan)"
- export LINK="$(asan)"
+ export CXX=$(asan)
+ export CXX_host=$(asan)
+ export LINK=$(asan)
export ASAN_SYMBOLIZER_PATH="$(dir $(asan))llvm-symbolizer"
endif
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index
4a70d6f7a719cdc6c39859996ed1a4f48cbbccca..dc25036daa67c544e13c119e546d3c2862b7deb8
100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -521,10 +521,7 @@
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or OS=="netbsd"
or \
OS=="qnx"', {
- 'cflags':
[ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
- '-Wnon-virtual-dtor', '-Woverloaded-virtual',
- '<(wno_array_bounds)',
- ],
+ 'cflags': [ '-Woverloaded-virtual', '<(wno_array_bounds)', ],
'conditions': [
['v8_optimized_debug==0', {
'cflags!': [
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
